fix(net): honor Ctrl-C during a retry backoff - #888
Merged
Conversation
Base automatically changed from
fix/honor-ctrl-c-during-bottle-download
to
main
August 21, 2026 19:58
indaco
force-pushed
the
fix/honor-ctrl-c-during-retry-backoff
branch
from
August 21, 2026 19:58
28fdcfe to
b026a06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A Ctrl-C arriving while a network request was waiting to be retried was
ignored. The wait ran to the end of its schedule - up to 7s across a retry
loop - and then re-dialled anyway, so a cancel during a flaky download or
metadata fetch took seconds to take effect and cost extra round trips first.
The wait now notices the cancel and stops, which is what its own comment
already claimed it did.
Related Issue
Notes for Reviewers
Stacked on
fix/honor-ctrl-c-during-bottle-download; review that one first.